Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken REST host fallbacks #1278

Merged
merged 57 commits into from
Apr 19, 2024
Merged

Fix broken REST host fallbacks #1278

merged 57 commits into from
Apr 19, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 26, 2024 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 26, 2024 18:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 27, 2024 09:08 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 27, 2024 09:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 27, 2024 10:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 27, 2024 14:14 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from e1e0ccd to 0f058c7 Compare March 27, 2024 17:32
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 27, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 03:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 03:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 03:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 04:05 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 08:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features March 28, 2024 09:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 18, 2024 12:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 18, 2024 18:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 18, 2024 18:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 05:04 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from 2ea0768 to c2d5739 Compare April 19, 2024 05:31
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 05:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 05:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 08:04 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from 1d5e766 to 2e1fd01 Compare April 19, 2024 08:13
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 08:13 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from 2e1fd01 to 169997a Compare April 19, 2024 08:24
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 08:25 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from 169997a to 9a80c7e Compare April 19, 2024 09:02
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 09:02 Inactive
@sacOO7 sacOO7 requested a review from VeskeR April 19, 2024 11:51
VeskeR
VeskeR requested changes Apr 19, 2024
View reviewed changes
Copy link

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have couple of comments.

src/IO.Ably.Shared/Http/AblyHttpClient.cs Outdated Show resolved Hide resolved
src/IO.Ably.Shared/Http/AblyHttpClient.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1278/features April 19, 2024 14:29 Inactive
@sacOO7 sacOO7 force-pushed the fix/broken-fallbacks branch from 4d06b27 to df35dbd Compare April 19, 2024 14:34
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 19, 2024

Thanks for approval, merging the PR : )

@sacOO7 sacOO7 merged commit 6a4b476 into main Apr 19, 2024
7 of 9 checks passed
@sacOO7 sacOO7 deleted the fix/broken-fallbacks branch April 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic left review comments

@VeskeR VeskeR VeskeR approved these changes

@owenpearson owenpearson Awaiting requested review from owenpearson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix rest host fallbacks
3 participants
@sacOO7 @VeskeR @ttypic